> On July 1, 2015, 9:54 p.m., Marco Massenzio wrote: > > src/linux/cgroups.cpp, line 2002 > > <https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2002> > > > > and, in any event, the variables should have a meaningful name - should > > these be `userTime` or something? > > (also, if they are time durations, please pre-pend the unit: > > `userTimeSec`)
Do you mean the argument names or member variable names? - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90140 ----------------------------------------------------------- On July 1, 2015, 9:38 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36106/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 9:38 p.m.) > > > Review request for mesos, Ian Downes, Joris Van Remoortere, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > cgroups implementation does not have a cpuacct subsystem implementation as of > today. Adding the implementation for stat function. > > Changes: > - added Stats class to encapsulate cpuacct.stat data > - added implementation for cpuacct::stats > - added unit tests > > Jira: MESOS-2961 > > > Diffs > ----- > > src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 > src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 > src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a > > Diff: https://reviews.apache.org/r/36106/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
