> On July 6, 2015, 2:36 a.m., Benjamin Hindman wrote:
> > Ship It!

Thanks Joseph! It would be great to follow up this with JIRA + reviews that 
eliminate the use of 'value' from a lot of our existing code that uses Path.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36116/#review90425
-----------------------------------------------------------


On July 6, 2015, 2:34 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36116/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 2:34 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2965
>     https://issues.apache.org/jira/browse/MESOS-2965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-2965: Add implicit conversion from Path to std::string.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
> a4afdad0b5f053186ace4d6a37b41cd02e7d415b 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
> 3211a0d6b88d06b396678eaf20128698f576d198 
> 
> Diff: https://reviews.apache.org/r/36116/diff/
> 
> 
> Testing
> -------
> 
> One unit test to demonstrate statically-checked conversion of Path to string.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to