> On July 8, 2015, 9:35 a.m., Marco Massenzio wrote:
> > docs/configuration.md, line 1031
> > <https://reviews.apache.org/r/36294/diff/1/?file=1001995#file1001995line1031>
> >
> >     it would be awesome if we could have an exhaustive list of allowed time 
> > units: eg, is msecs or usecs allowed? what about `days`?
> >     
> >     and, I presume only ints are allowed, but it would be nice to make it 
> > clear (eg, `0.5mins` is not allowed).
> >     
> >     also, one has to *infer* that the singular form is *not* allowed 
> > (`1mins` in the default) but it would be nice to spell it out for the unwary

What? Isn't it obvious from 
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp#L51
 what units are allowed? ;P
Also, doubles are allowed, but no negative values (yet). 
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp#L38


> On July 8, 2015, 9:35 a.m., Marco Massenzio wrote:
> > docs/configuration.md, line 91
> > <https://reviews.apache.org/r/36294/diff/1/?file=1001995#file1001995line91>
> >
> >     unnecessary blank line
> >     (and I would add a simple example, and state that this has to actually 
> > be an IP address, can't just be a DNS name) and should have no port info.

These blank lines are scattered through several flags, so I'll leave them alone 
for now.
As for an IP example, I was really just moving this flag into alpha-order. The 
real change needs to happen in master/main.cpp and slave/main.cpp.


> On July 8, 2015, 9:35 a.m., Marco Massenzio wrote:
> > docs/configuration.md, line 81
> > <https://reviews.apache.org/r/36294/diff/1/?file=1001995#file1001995line81>
> >
> >     nit: Google (uppercase)

Fixed this in the configuration and in src/logging/flags.cpp


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36294/#review90913
-----------------------------------------------------------


On July 8, 2015, 1:18 a.m., Adam B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36294/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 1:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Joris Van 
> Remoortere, Marco Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-2727
>     https://issues.apache.org/jira/browse/MESOS-2727
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> See Summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9a8505d 
> 
> Diff: https://reviews.apache.org/r/36294/diff/
> 
> 
> Testing
> -------
> 
> I went through each of the flags.hpp's and made sure each flag was 
> represented.
> I did not go so far as to check for text rewordings.
> 
> Rendered at https://www.notehub.org/2015/7/8/mesos-configuration
> 
> Some of you Shepherded/committed new flags in 0.23.0 without any 
> corresponding configuration.md update.
> Let's try to make sure updating configuration.md is included as a part of 
> whatever feature work introduces the new flag, so that future release 
> managers don't have to document your feature for you.
> 
> 
> Thanks,
> 
> Adam B
> 
>

Reply via email to