> On July 8, 2015, 10:24 a.m., Jie Yu wrote: > > docs/configuration.md, lines 1295-1301 > > <https://reviews.apache.org/r/36294/diff/1/?file=1001995#file1001995line1295> > > > > This one is being deprecated. Maybe you want to call it out?
Shouldn't we also call that out in the Flags help in src/slave/flags.cpp? That seems more important for those already using the flag. If we're actually deprecating it, we should be printing a warning message somewhere if it's used. And it should go into the Deprecation section of the CHANGELOG. As it is, I don't even see this flag being used anywhere (maybe my grep-fu is off). I'm going to leave this one alone for now. If somebody wants to officially deprecate this flag, they can submit a separate patch. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36294/#review90927 ----------------------------------------------------------- On July 8, 2015, 1:18 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36294/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 1:18 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Joris Van > Remoortere, Marco Massenzio, and Vinod Kone. > > > Bugs: MESOS-2727 > https://issues.apache.org/jira/browse/MESOS-2727 > > > Repository: mesos-incubating > > > Description > ------- > > See Summary. > > > Diffs > ----- > > docs/configuration.md 9a8505d > > Diff: https://reviews.apache.org/r/36294/diff/ > > > Testing > ------- > > I went through each of the flags.hpp's and made sure each flag was > represented. > I did not go so far as to check for text rewordings. > > Rendered at https://www.notehub.org/2015/7/8/mesos-configuration > > Some of you Shepherded/committed new flags in 0.23.0 without any > corresponding configuration.md update. > Let's try to make sure updating configuration.md is included as a part of > whatever feature work introduces the new flag, so that future release > managers don't have to document your feature for you. > > > Thanks, > > Adam B > >
