> On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/http.cpp, lines 135-143
> > <https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line135>
> >
> >     Can we get these comments back ?

They're on the header file now, do we want them duplciate here?


> On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/http.cpp, lines 145-146
> > <https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line145>
> >
> >     Can we put these comments back ?

Because rules aren't here anymore but in the header file. I thought it was 
confusing to let this here.


> On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/http.cpp, lines 169-177
> > <https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line169>
> >
> >     Same here.

same here, moved to header.


> On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/http.cpp, line 126
> > <https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line126>
> >
> >     Whoops ! Let's return false as earlier. Also add a test-case for empty 
> > check. ( Accept-Encoding )

Added a TODO since it's not standard to return false here.


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91843
-----------------------------------------------------------


On July 15, 2015, 11:54 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36402/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 11:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and 
> Vinod Kone.
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Adding a method for Accept header in request + refactor of Accept-Encoding
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 72b6d27 
>   3rdparty/libprocess/src/http.cpp d168579 
>   3rdparty/libprocess/src/tests/http_tests.cpp 01f243c 
> 
> Diff: https://reviews.apache.org/r/36402/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Reply via email to