> On July 16, 2015, 12:10 a.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/http.cpp, line 126
> > <https://reviews.apache.org/r/36402/diff/3/?file=1012922#file1012922line126>
> >
> >     Whoops ! Let's return false as earlier. Also add a test-case for empty 
> > check. ( Accept-Encoding )
> 
> Isabel Jimenez wrote:
>     Added a TODO since it's not standard to return false here.
> 
> Anand Mazumdar wrote:
>     Looks like I am missing something here. This is a method for 
> Accept-Encoding. If the header is not present and you pass "gzip" as argument 
> to the method , it should return false as was the case earlier since the 
> client can't accept "gzip" ( gzip is a bad example here owing to the 
> exception in the rfc around it/compress). Did you get confused with it being 
> the "Accept" header ?
>     
>     Re-opening the issue for now. I think we can get rid of the TODO here.
> 
> Isabel Jimenez wrote:
>     `Accept` and `Accept-encoding` have the same behavior in this case. From 
> RFC 14.3 Accept-Encoding : If no Accept-Encoding field is present in a 
> request, the server MAY assume that the client will accept any content coding.

// TODO(ijimenez): Return true here, from RFC:
  // If no Accept header field is present, then it is assumed
  // that the client accepts all media types.
  
Looks like there was some confusion here around the TODO . It did not make 
sense here since this method was for Accept-Encoding. You can modify it to:

  // TODO(ijimenez): Return true here, from RFC:
  // If no Accept-Encoding header field is present, then it may be assumed
  // that the client accepts all content-codings.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91843
-----------------------------------------------------------


On July 15, 2015, 11:54 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36402/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 11:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and 
> Vinod Kone.
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Adding a method for Accept header in request + refactor of Accept-Encoding
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 72b6d27 
>   3rdparty/libprocess/src/http.cpp d168579 
>   3rdparty/libprocess/src/tests/http_tests.cpp 01f243c 
> 
> Diff: https://reviews.apache.org/r/36402/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Reply via email to