-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34141/#review91685
-----------------------------------------------------------



src/slave/containerizer/provisioners/appc/backend.hpp (line 41)
<https://reviews.apache.org/r/34141/#comment145761>

    In terms of the name `Backend`, I am not sure if it captures what it does 
precisely.
    
    There is Provisioner::provision() and there is Backend::provision().
    
    If "provision" means the overarching action then this specific step is 
really "installing" the downloaded images.
    
    Thoughts?



src/slave/containerizer/provisioners/appc/backend.cpp (lines 128 - 133)
<https://reviews.apache.org/r/34141/#comment145250>

    For this to work, should we check the pre-condition: `directory` has to 
already exist,  otherwise `rootfs` is copied to `directory` rather than 
`directory/rootfs`.
    
    I assume this is what we want given the bind mount backend implemetation:
    
    A simple illustration of directory layout (in `paths.hpp`) is hugely 
helpful.


- Jiang Yan Xu


On July 7, 2015, 12:43 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34141/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 12:43 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Simple copy backend that forms the rootfs by copying each layer.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 
>   src/slave/containerizer/provisioners/appc/backend.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/backend.cpp PRE-CREATION 
>   src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b 
>   src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 
> 
> Diff: https://reviews.apache.org/r/34141/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to