----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92459 -----------------------------------------------------------
src/linux/cgroups.cpp (line 1671) <https://reviews.apache.org/r/36620/#comment146638> It's very odd to see the failure message set here but then a lot more attempts to try to set it in the finished callback. How about having a failed method that sets the failure and another finished callback that is what you have? src/linux/cgroups.cpp (line 1683) <https://reviews.apache.org/r/36620/#comment146637> Very wierd identation? src/linux/cgroups.cpp (line 1686) <https://reviews.apache.org/r/36620/#comment146634> //check -> // Check src/linux/cgroups.cpp (line 1688) <https://reviews.apache.org/r/36620/#comment146636> one more space to the right src/linux/cgroups.cpp (line 1708) <https://reviews.apache.org/r/36620/#comment146635> extra space between "the" and "pids" - Timothy Chen On July 21, 2015, 5:18 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36620/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 5:18 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3086 > https://issues.apache.org/jira/browse/MESOS-3086 > > > Repository: mesos > > > Description > ------- > > WIP Added Non-Freezeer Task Killer. > > > Diffs > ----- > > src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e > > Diff: https://reviews.apache.org/r/36620/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > >
