-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92774
-----------------------------------------------------------



src/linux/cgroups.cpp (line 1672)
<https://reviews.apache.org/r/36620/#comment147016>

    Why we need a new promise here? Why can't we use promise variable you 
created in the class?



src/linux/cgroups.cpp (line 1678)
<https://reviews.apache.org/r/36620/#comment147017>

    "Failed to get cgroup processes: " + processes.error()



src/linux/cgroups.cpp (line 1696)
<https://reviews.apache.org/r/36620/#comment147015>

    Seems like we can just a lambda instead of a new fail method, then we don't 
even need to store chain variable right?



src/linux/cgroups.cpp (line 1713)
<https://reviews.apache.org/r/36620/#comment147014>

    I don't think the error message includes the original intention right?
    
    "Failed to cgroups kill: " + kill.error()


- Timothy Chen


On July 23, 2015, 12:21 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 12:21 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
>     https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 
> 
> Diff: https://reviews.apache.org/r/36620/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to