----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92683 -----------------------------------------------------------
src/linux/cgroups.cpp (line 1627) <https://reviews.apache.org/r/36620/#comment146907> I think it's good to also describe what the killer does and why it needs to recursively kill. src/linux/cgroups.cpp (line 1859) <https://reviews.apache.org/r/36620/#comment146910> I don't think this log is necessary, at very least VLOG(1) - Timothy Chen On July 22, 2015, 10:04 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36620/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 10:04 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3086 > https://issues.apache.org/jira/browse/MESOS-3086 > > > Repository: mesos > > > Description > ------- > > WIP Added Non-Freezeer Task Killer. > > > Diffs > ----- > > src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 > > Diff: https://reviews.apache.org/r/36620/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > >
