----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92556 -----------------------------------------------------------
Bad patch! Reviews applied: [36677] Failed command: ./support/apply-review.sh -n -r 36677 Error: 2015-07-22 06:28:31 URL:https://reviews.apache.org/r/36677/diff/raw/ [10398/10398] -> "36677.patch" [1] Successfully applied: Introduced 'recordio' encoding facilities to stout. Note that most "Record-IO" encodings are used for file I/O and consequently use a fixed-size header to encode the record length. However, decoding a base-10 integer is more straightforward to implement in most languages, and so this was chosen instead. (Note that the Twitter streaming API uses the same technique for portability). Review: https://reviews.apache.org/r/36677 Checking 3 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo Total errors found: 0 ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: stout: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp libprocess: 3rdparty/libprocess/3rdparty/Makefile.am Failed to commit patch - Mesos ReviewBot On July 22, 2015, 6:09 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36677/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 6:09 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu. > > > Bugs: MESOS-3067 > https://issues.apache.org/jira/browse/MESOS-3067 > > > Repository: mesos > > > Description > ------- > > Note that most "Record-IO" encodings are used for file I/O > and consequently use a fixed-size header to encode the record > length. However, decoding a base-10 integer is more > straightforward to implement in most languages, and so this > was chosen instead. (Note that the Twitter streaming API > uses the same technique for portability). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 856c2b289451fd404b97285b825e72913feb2f04 > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 2394b95462182273464f0847f416ad83c3b64485 > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 8c75f6b28c18596018eaefe427b238424aae2fd9 > 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36677/diff/ > > > Testing > ------- > > Added tests. > > > Thanks, > > Ben Mahler > >
