----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92626 -----------------------------------------------------------
nice tests! 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp (lines 54 - 61) <https://reviews.apache.org/r/36677/#comment146834> Add comments! 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp (lines 72 - 73) <https://reviews.apache.org/r/36677/#comment146836> Comment please. 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp (line 83) <https://reviews.apache.org/r/36677/#comment146837> Can you add a comment about whether data can contain a partial record? - Vinod Kone On July 22, 2015, 6:33 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36677/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 6:33 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu. > > > Bugs: MESOS-3067 > https://issues.apache.org/jira/browse/MESOS-3067 > > > Repository: mesos > > > Description > ------- > > Note that most "Record-IO" encodings are used for file I/O > and consequently use a fixed-size header to encode the record > length. However, decoding a base-10 integer is more > straightforward to implement in most languages, and so this > was chosen instead. (Note that the Twitter streaming API > uses the same technique for portability). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 2394b95462182273464f0847f416ad83c3b64485 > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 8c75f6b28c18596018eaefe427b238424aae2fd9 > 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36677/diff/ > > > Testing > ------- > > Added tests. > > > Thanks, > > Ben Mahler > >
