----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92690 -----------------------------------------------------------
I'll add a note about "completion" semantics (surface an error when the stream ends with a partial record). This is not immediately useful but note that it is provided by joyent's http parser: https://github.com/joyent/http-parser (search for EOF). 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp (line 29) <https://reviews.apache.org/r/36677/#comment146918> I'll add a TODO here that it would be nice to compose asynchronous streams of data, e.g.: Stream<string> | Decoder<Event> -> Stream<Event> But we don't have the necessary abstractions yet in libprocess. 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp (line 156) <https://reviews.apache.org/r/36677/#comment146917> Add a note about memory allocation here, the string will retain its maximum size after a .clear() call: http://stackoverflow.com/q/25974085 - Ben Mahler On July 22, 2015, 11:24 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36677/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 11:24 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu. > > > Bugs: MESOS-3067 > https://issues.apache.org/jira/browse/MESOS-3067 > > > Repository: mesos > > > Description > ------- > > Note that most "Record-IO" encodings are used for file I/O > and consequently use a fixed-size header to encode the record > length. However, decoding a base-10 integer is more > straightforward to implement in most languages, and so this > was chosen instead. (Note that the Twitter streaming API > uses the same technique for portability). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 2394b95462182273464f0847f416ad83c3b64485 > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 8c75f6b28c18596018eaefe427b238424aae2fd9 > 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36677/diff/ > > > Testing > ------- > > Added tests. > > > Thanks, > > Ben Mahler > >
