-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36683/#review92621
-----------------------------------------------------------



src/tests/persistent_volume_tests.cpp (lines 595 - 596)
<https://reviews.apache.org/r/36683/#comment146829>

    Can you expand the comment on what it means for proper recovery? I couldn't 
tell from reading the test. Are you not expected to get TASK_KILLED if recovery 
fails?



src/tests/persistent_volume_tests.cpp (lines 641 - 648)
<https://reviews.apache.org/r/36683/#comment146830>

    This task doesn't look like it is writing a file but rather testing if the 
directory is present in a while loop?


- Vinod Kone


On July 22, 2015, 6:59 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36683/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 6:59 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3124
>     https://issues.apache.org/jira/browse/MESOS-3124
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a persistent volume test for slave recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 
> c5f72d5b7a118eb121e268f982955c73159a61e1 
> 
> Diff: https://reviews.apache.org/r/36683/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> NOTE: this test will fail if the subsequent patch is not applied.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to