----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/#review92665 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp (line 598) <https://reviews.apache.org/r/36683/#comment146889> s/TASK_FAILED/TASK_FAILED after slave finishes recovery/ ? src/tests/persistent_volume_tests.cpp (line 700) <https://reviews.apache.org/r/36683/#comment146890> Would it receive TASK_FAILED here or immediately after slave recovery finishes, irrespective of whether killTask was called? Also, I would revert the dependency order of these reviews or just merge them. - Vinod Kone On July 22, 2015, 8:09 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36683/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 8:09 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Bugs: MESOS-3124 > https://issues.apache.org/jira/browse/MESOS-3124 > > > Repository: mesos > > > Description > ------- > > Added a persistent volume test for slave recovery. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > c5f72d5b7a118eb121e268f982955c73159a61e1 > > Diff: https://reviews.apache.org/r/36683/diff/ > > > Testing > ------- > > make check > > NOTE: this test will fail if the subsequent patch is not applied. > > > Thanks, > > Jie Yu > >
