> On July 22, 2015, 6:22 p.m., Vinod Kone wrote: > > src/tests/persistent_volume_tests.cpp, lines 641-648 > > <https://reviews.apache.org/r/36683/diff/1/?file=1018474#file1018474line641> > > > > This task doesn't look like it is writing a file but rather testing if > > the directory is present in a while loop?
Yes, it's testing if the persistent volume directory exists or not. Without applying the patch, the volume directory will be removed incorrectly and the task will become TASK_FAILED. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/#review92621 ----------------------------------------------------------- On July 22, 2015, 6:59 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36683/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 6:59 a.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Bugs: MESOS-3124 > https://issues.apache.org/jira/browse/MESOS-3124 > > > Repository: mesos > > > Description > ------- > > Added a persistent volume test for slave recovery. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > c5f72d5b7a118eb121e268f982955c73159a61e1 > > Diff: https://reviews.apache.org/r/36683/diff/ > > > Testing > ------- > > make check > > NOTE: this test will fail if the subsequent patch is not applied. > > > Thanks, > > Jie Yu > >
