> On July 28, 2015, 3:17 a.m., Adam B wrote: > > docs/committer-candidate-checklist.md, line 9 > > <https://reviews.apache.org/r/36197/diff/3/?file=1004883#file1004883line9> > > > > I'm not convinced these `<input type="text"/>` will actually show up on > > the website, or even github. > > > > Let's leave `Nomination date` out of the checklist, since that comes > > implicitly when the nominator makes the actual nomination, and is > > impossible to guess before then.
I tested the input boxes in a git gist. Indeed, no text box appears, but that's not a problem IMHO. The colon followed by white space makes it clear enough where text can be added. In other MD renderers the boxes do show up. > On July 28, 2015, 3:17 a.m., Adam B wrote: > > docs/committer-candidate-checklist.md, lines 22-26 > > <https://reviews.apache.org/r/36197/diff/3/?file=1004883#file1004883line22> > > > > These are rather vague. Are they meant to be filled in by the Nominator > > or the candidate? Either way, it'd be nice to give some hints/examples of > > how these would be demonstrated. This can be filled out by anybody. And not giving any guidance here is intended. This is part of the homework. > On July 28, 2015, 3:17 a.m., Adam B wrote: > > docs/committer-candidate-checklist.md, lines 35-36 > > <https://reviews.apache.org/r/36197/diff/3/?file=1004883#file1004883line35> > > > > Another one that the candidate can't fill out themselves. > > Maybe it would be best to break this down into the "candidate > > checklist" part that the candidate fills out (all my ids/stats/queries, > > etc.) and the "nomination form" that the nominator fills out. The candidate can fill out every part. This is not a signature, just listing who will vouch. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review93265 ----------------------------------------------------------- On July 28, 2015, 1:11 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36197/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 1:11 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1815 > https://issues.apache.org/jira/browse/MESOS-1815 > > > Repository: mesos > > > Description > ------- > > Added new document "committer-candidate-checklist.md" and wrote > a paragraph about the path to committership in "committers.md". > > > Diffs > ----- > > docs/committer-candidate-checklist.md PRE-CREATION > docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 > > Diff: https://reviews.apache.org/r/36197/diff/ > > > Testing > ------- > > The rendered files can be viewed here: > > https://gist.github.com/bernd-mesos/00de63ae13efec4331be > > > Thanks, > > Bernd Mathiske > >
