----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36958/#review93658 -----------------------------------------------------------
Mind adding a test for this if one doesn't exist already? Should be straightforward. src/master/master.cpp (lines 1565 - 1573) <https://reviews.apache.org/r/36958/#comment148069> why the nested if loop? ``` if (frameworkInfo.has_principal() && authenticated.contains(from) && fraemworkInfo.principal() != authenticated[from]) { } ``` src/master/master.cpp (line 1567) <https://reviews.apache.org/r/36958/#comment148070> not yours, but s/framweworks/frameworks/ - Vinod Kone On July 30, 2015, 10:16 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36958/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 10:16 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > When --flags.authenticate_frameworks is false, we still should be > checking that the authenticated principal matches the framework's > principal. > > > Diffs > ----- > > src/master/master.cpp 8162b2b796c9712a7b2d544118fe8de2646a8d32 > > Diff: https://reviews.apache.org/r/36958/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
