----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36958/#review93687 -----------------------------------------------------------
Bad patch! Reviews applied: [36927] Failed command: ./support/apply-review.sh -n -r 36927 Error: 2015-07-31 00:49:14 URL:https://reviews.apache.org/r/36927/diff/raw/ [19346/19346] -> "36927.patch" [1] error: patch failed: src/master/master.hpp:575 error: src/master/master.hpp: patch does not apply error: patch failed: src/master/master.cpp:1524 error: src/master/master.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On July 30, 2015, 11:54 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36958/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 11:54 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > When --flags.authenticate_frameworks is false, we still should be > checking that the authenticated principal matches the framework's > principal. > > > Diffs > ----- > > src/master/master.cpp ce27dbe58d0afc2363991695e7af212616e1f09a > src/tests/authentication_tests.cpp 5126ed4acbdf4c8508133bed35f98b0da3cca11e > > Diff: https://reviews.apache.org/r/36958/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >