----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36958/#review93679 -----------------------------------------------------------
Ship it! src/tests/authentication_tests.cpp (line 199) <https://reviews.apache.org/r/36958/#comment148095> s/,/ than Credential::principal/ ? s/when/even when/ ? do we already have a test for when authentication is required? if not, would be nice to have one. maybe parameterize this test? - Vinod Kone On July 30, 2015, 11:54 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36958/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 11:54 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > When --flags.authenticate_frameworks is false, we still should be > checking that the authenticated principal matches the framework's > principal. > > > Diffs > ----- > > src/master/master.cpp ce27dbe58d0afc2363991695e7af212616e1f09a > src/tests/authentication_tests.cpp 5126ed4acbdf4c8508133bed35f98b0da3cca11e > > Diff: https://reviews.apache.org/r/36958/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
