----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review93906 -----------------------------------------------------------
src/local/local.cpp (line 221) <https://reviews.apache.org/r/36049/#comment148332> That's a bit too subtle for me. Proposals, either: - pass the acls to the custom authorizer and let it decide what to do with them - or disallow the presence of both flags, terminate the slave with an error. The latter would also greatly simplify the control flow here. src/master/flags.cpp (line 230) <https://reviews.apache.org/r/36049/#comment148333> See above. IMHO better to disallow having both flags simultaneously. If the user gives contradictory instructions, the slave should not start. src/master/flags.cpp (line 421) <https://reviews.apache.org/r/36049/#comment148335> See above. src/master/main.cpp (line 305) <https://reviews.apache.org/r/36049/#comment148336> See above. - Bernd Mathiske On Aug. 3, 2015, 2:47 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36049/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2015, 2:47 a.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till > Toenshoff. > > > Bugs: MESOS-2947 > https://issues.apache.org/jira/browse/MESOS-2947 > > > Repository: mesos > > > Description > ------- > > Adds and integrates helper classes needed to support an `Authorizer` module. > Also adds a flag to the master, allowing the selection of an `Authorizer` > module. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp PRE-CREATION > include/mesos/module/authorizer.hpp PRE-CREATION > src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 > src/authorizer/authorizer.cpp PRE-CREATION > src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff > src/master/constants.hpp 7cec18b7fdfd3b96cde42a30d217c026b2695dce > src/master/constants.cpp fbcae60c43e835f96ec061bd0e9f7961e31fc341 > src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f > src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756 > src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 > src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 > > Diff: https://reviews.apache.org/r/36049/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
