> On Aug. 3, 2015, 4:34 p.m., Bernd Mathiske wrote: > > src/local/local.cpp, line 221 > > <https://reviews.apache.org/r/36049/diff/8/?file=1017149#file1017149line221> > > > > That's a bit too subtle for me. Proposals, either: > > - pass the acls to the custom authorizer and let it decide what to do > > with them > > - or disallow the presence of both flags, terminate the slave with an > > error. > > > > The latter would also greatly simplify the control flow here.
The ideal would be to remove the whole `Authorizer::initialize()`, however we cannot disallow the presence of both flags since `--authorizers` is always set (with a default value). True, the code ain't pretty, but instead of giving it a make up, I would rather push for a long term solution (removing the initialize method at least with that signature), and then entirely remove this code. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review93906 ----------------------------------------------------------- On Aug. 4, 2015, 6:26 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36049/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 6:26 p.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till > Toenshoff. > > > Bugs: MESOS-2947 > https://issues.apache.org/jira/browse/MESOS-2947 > > > Repository: mesos > > > Description > ------- > > Adds and integrates helper classes needed to support an `Authorizer` module. > Also adds a flag to the master, allowing the selection of an `Authorizer` > module. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp PRE-CREATION > include/mesos/module/authorizer.hpp PRE-CREATION > src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec > src/authorizer/authorizer.cpp PRE-CREATION > src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff > src/master/constants.hpp 7cec18b7fdfd3b96cde42a30d217c026b2695dce > src/master/constants.cpp fbcae60c43e835f96ec061bd0e9f7961e31fc341 > src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f > src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756 > src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce > src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670 > src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b > > Diff: https://reviews.apache.org/r/36049/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
