----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review94576 -----------------------------------------------------------
Patch looks great! Reviews applied: [35711] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 6:50 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 6:50 p.m.) > > > Review request for mesos, Adam B, Jie Yu, and Michael Park. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > include/mesos/roles.hpp PRE-CREATION > src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 > src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 > src/common/roles.cpp PRE-CREATION > src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756 > src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e > src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 > src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e > src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 > src/tests/roles_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
