----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94781 -----------------------------------------------------------
Ship it! Maybe the code around checking for acceptable headers would benefit from using a RegEx instead of "parsing by hand" - but apart from that, LGTM. 3rdparty/libprocess/src/http.cpp (lines 213 - 215) <https://reviews.apache.org/r/36402/#comment149377> you can just use `strings.trim()` here 3rdparty/libprocess/src/http.cpp (lines 219 - 220) <https://reviews.apache.org/r/36402/#comment149381> I'm not sure I understand why you do this. Can you please comment or explain? - Marco Massenzio On Aug. 5, 2015, 7:11 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36402/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 7:11 p.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and > Vinod Kone. > > > Repository: mesos-incubating > > > Description > ------- > > Adding a method for Accept header in request + refactor of Accept-Encoding > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp b8d9300 > 3rdparty/libprocess/src/http.cpp 4dcbd74 > 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5 > > Diff: https://reviews.apache.org/r/36402/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
