> On Aug. 10, 2015, 7:03 p.m., Marco Massenzio wrote:
> > 3rdparty/libprocess/src/http.cpp, lines 219-220
> > <https://reviews.apache.org/r/36402/diff/10/?file=1032819#file1032819line219>
> >
> > I'm not sure I understand why you do this.
> > Can you please comment or explain?
Here we introduce two other strings we want to make sure we use to validate
what the client is sending in its header.
If the client sends '*/*' and we want to make sure he accepts 'foo/bar', but we
only compare 'foo/bar' with '*/*' we will reject a valid header.
So we introduce what we are expecting the client to send as a valid header so
we can compare both and send back true when the client is sending '*/*' and we
compare it first with 'foo/bar' then with 'foo/*' then finally with '*/*'. This
means the client accepts anything ('foo/bar' included) so we validate the
header.
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94781
-----------------------------------------------------------
On Aug. 5, 2015, 7:11 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36402/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 7:11 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and
> Vinod Kone.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Adding a method for Accept header in request + refactor of Accept-Encoding
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp b8d9300
> 3rdparty/libprocess/src/http.cpp 4dcbd74
> 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd5
>
> Diff: https://reviews.apache.org/r/36402/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
