-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/#review94861
-----------------------------------------------------------


Looks good overall! One question: why did you decide to leave the `hash_value` 
functions and call it from `std::hash` specializations rather than moving the 
logic?

- Michael Park


On Aug. 10, 2015, 12:25 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37188/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 12:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
>     https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/address.hpp 
> df78f8e525c40b87e734e16979d3315f89e12594 
>   3rdparty/libprocess/include/process/pid.hpp 
> 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> ecbcbd552ac834659860627c82628ed38e6139b3 
> 
> Diff: https://reviews.apache.org/r/37188/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to