----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96593 -----------------------------------------------------------
@Mpark: For the standard hashers, do we want to follow this pattern? ``` template <> struct hash<T> { typedef size_t result_type; typedef T argument_type; result_type operator()(const argument_type &that) const { // body } }; ``` Are we replacing all uses of the hash based boost containers? If so, should we clean up the remaining instances of `hash_value` implementations? Grepping through I still see some. 3rdparty/libprocess/include/process/pid.hpp (line 153) <https://reviews.apache.org/r/37188/#comment152176> there is an extra space hiding here :-) 3rdparty/libprocess/src/tests/http_tests.cpp (line 806) <https://reviews.apache.org/r/37188/#comment152180> I think we tend to put a new line after an expression that doesn't fit on 1 line. Same for the one below. - Joris Van Remoortere On Aug. 25, 2015, 1:15 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37188/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 1:15 p.m.) > > > Review request for mesos, Alexander Rojas and Michael Park. > > > Bugs: MESOS-3217 > https://issues.apache.org/jira/browse/MESOS-3217 > > > Repository: mesos > > > Description > ------- > > Added std::hash template specializations. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/address.hpp > df78f8e525c40b87e734e16979d3315f89e12594 > 3rdparty/libprocess/include/process/pid.hpp > 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 > 3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 > 3rdparty/libprocess/src/tests/http_tests.cpp > c22f9d35b5dc959ce9816d3358ebff92b853bf52 > > Diff: https://reviews.apache.org/r/37188/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >