-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review95129
-----------------------------------------------------------



src/master/master.hpp (lines 921 - 925)
<https://reviews.apache.org/r/37172/#comment149949>

    I think we should move this backwards in the review chain 
(https://reviews.apache.org/r/37314/).
    
    We can combine it with
    ```
    hashmap<MachineInfo, mesos::maintenance::Mode> maintenanceStatuses;
    ```
    (https://reviews.apache.org/r/37314/diff/1#1.6)
    
    Possibly like:
    ```
    struct MaintenanceInfo {
      Unavailability unavailability;
      mesos::maintenance::mode mode;
    }
    hashmap<MachineInfo, MaintenanceInfo> maintenanceInfos;
    ```


- Joseph Wu


On Aug. 10, 2015, 12:04 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3 
>   src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 
>   src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288 
> 
> Diff: https://reviews.apache.org/r/37172/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to