-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review95781
-----------------------------------------------------------

Ship it!



include/mesos/maintenance/maintenance.hpp (line 37)
<https://reviews.apache.org/r/37172/#comment150905>

    Trailing whitespace.



src/master/master.hpp (lines 288 - 289)
<https://reviews.apache.org/r/37172/#comment150906>

    Should we standardize how we refer to the maintenance modes in comments?
    
    I've referred to the modes as pronouns [Normal, Draining, Deactivated].  We 
could change them all to be `screaming`-case.  Or to pronoun-case.


- Joseph Wu


On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 11:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/tests/master_maintenance_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37172/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to