-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95321
-----------------------------------------------------------


I re-created the issues from the previous avatar 
(https://reviews.apache.org/r/36867).


src/tests/fault_tolerance_tests.cpp (lines 1834 - 1837)
<https://reviews.apache.org/r/37443/#comment150207>

    You should be able to replace these lines with:
    `framework1.mutable_labels()->add_labels()->CopyFrom(createLabel("foo", 
"bar"));`



src/tests/fault_tolerance_tests.cpp (lines 1869 - 1872)
<https://reviews.apache.org/r/37443/#comment150208>

    same as above



src/tests/fault_tolerance_tests.cpp (lines 1944 - 1950)
<https://reviews.apache.org/r/37443/#comment150209>

    This block can be replaced with:
    
        EXPECT_EQ(
            JSON::Value(JSON::Protobuf(createLabel("foo", "bar"))),
         labelsObject.values[0]);



src/tests/master_tests.cpp (line 3604)
<https://reviews.apache.org/r/37443/#comment150218>

    Unused. Remove.



src/tests/master_tests.cpp (line 3608)
<https://reviews.apache.org/r/37443/#comment150211>

    There are only two labels below.



src/tests/master_tests.cpp (lines 3612 - 3622)
<https://reviews.apache.org/r/37443/#comment150210>

    same as above.



src/tests/master_tests.cpp (line 3637)
<https://reviews.apache.org/r/37443/#comment150216>

    two space indentation here.



src/tests/master_tests.cpp (lines 3650 - 3651)
<https://reviews.apache.org/r/37443/#comment150213>

    Indent by four space.



src/tests/master_tests.cpp (lines 3654 - 3655)
<https://reviews.apache.org/r/37443/#comment150214>

    Indent by four spaces.



src/tests/master_tests.cpp (lines 3658 - 3659)
<https://reviews.apache.org/r/37443/#comment150215>

    Indent by four spaces.


- Kapil Arya


On Aug. 13, 2015, 3:50 p.m., James DeFelice wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37443/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 3:50 p.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
>     https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> supercedes #36867 ; addressed outstanding review comments in that review
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a4a9c6f 
>   src/master/http.cpp 579c009 
>   src/master/master.hpp 4e29470 
>   src/tests/fault_tolerance_tests.cpp c63599a 
>   src/tests/master_tests.cpp a4703af 
> 
> Diff: https://reviews.apache.org/r/37443/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James DeFelice
> 
>

Reply via email to