-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95408
-----------------------------------------------------------

Ship it!


These mini issues can easily be fixed while committing. Great job on this 
project!


include/mesos/mesos.proto (line 192)
<https://reviews.apache.org/r/37443/#comment150343>

    s/scheduler/framework
    
    It will not be the scheduler providing the extra functionality. It just 
provides the labels describing it.



src/master/http.cpp (line 243)
<https://reviews.apache.org/r/37443/#comment150345>

    What do you mean by this comment? Confusing.
    
    BTW: in general, we do not mark existing code with the tickets it relates 
to. (We do mark TODOs with issues numbers if available, though.)
    
    IMHO this comment can simply be deleted.


- Bernd Mathiske


On Aug. 13, 2015, 1:20 p.m., James DeFelice wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37443/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 1:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
>     https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> supercedes #36867 ; addressed outstanding review comments in that review
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a4a9c6f 
>   src/master/http.cpp 579c009 
>   src/master/master.hpp 4e29470 
>   src/tests/fault_tolerance_tests.cpp c63599a 
>   src/tests/master_tests.cpp a4703af 
> 
> Diff: https://reviews.apache.org/r/37443/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James DeFelice
> 
>

Reply via email to