> On Aug. 14, 2015, 1:49 p.m., Alexander Rojas wrote: > > src/tests/fault_tolerance_tests.cpp, line 1834 > > <https://reviews.apache.org/r/37443/diff/4/?file=1039554#file1039554line1834> > > > > Line length is 81 characters. > > James DeFelice wrote: > assuming that 80 is the limit? is there a common linter that you guys use?
yup 80 is the limit. We use clang format, the `.clang-format` is automatically generated when one runs `bootstrap` although it doesn't work perfectly to our rules. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95411 ----------------------------------------------------------- On Aug. 14, 2015, 1:29 p.m., James DeFelice wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37443/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 1:29 p.m.) > > > Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen. > > > Bugs: MESOS-2841 > https://issues.apache.org/jira/browse/MESOS-2841 > > > Repository: mesos > > > Description > ------- > > This is intended to support frameworks that want to offer capabilities to the > rest of the cluster (e.g., storage or some arbitrary third-party service). We > want processes running in the cluster to be able to discover these > capabilities; > however, we don't want to commit to a fixed set of capabilities or how those > capabilities should be represented. Hence, this commit represents this > information using freeform key-value pairs, similar to the labels mechanism > already in use elsewhere. > > Jira: MESOS-2841 > > supercedes #36867 ; addressed outstanding review comments in that review > > > Diffs > ----- > > include/mesos/mesos.proto a4a9c6f > src/master/http.cpp 579c009 > src/master/master.hpp 4e29470 > src/tests/fault_tolerance_tests.cpp c63599a > src/tests/master_tests.cpp a4703af > > Diff: https://reviews.apache.org/r/37443/diff/ > > > Testing > ------- > > make check > > > Thanks, > > James DeFelice > >
