> On Aug. 25, 2015, 2:55 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, line 129 > > <https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line129> > > > > For consistency, please one space between sentences! Here and below.
The codebase isn't consistent in this respect. But grammatically, 2 spaces is correct (notice that the ASF license text uses 2 spaces). > On Aug. 25, 2015, 2:55 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, lines 847-850 > > <https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line847> > > > > As per my comment for `InverseOffers`, let's clarify the contract and > > guarantees here. > > Alexander Rukletsov wrote: > Or, as I said earlier, we can pull the contarct description out and > reference it here. I actually left it out on purpose. The Unavailability in an Offer is a nugget of extra information about the resources. The presence of the unavailability shouldn't drastically alter how frameworks perceive the offer; an offer is still meant to be an allocation. If we put too much of the contract/guarantee logic into the offer, it'll start sounding like an offer for deallocation (that's what the InverseOffer is for). > On Aug. 25, 2015, 2:55 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, line 123 > > <https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line123> > > > > Let's add a comment saying it's not a generic range, but a range > > relative to unavailability event. I think the reason you do not use a more > > generic name is that you plan to add specific fields in the future. If this > > is the case, let's reflect it in the comment for posterity. If it's not, > > let's rename the message for something more general : ). I'll add a comment *and* a TODO :) - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96126 ----------------------------------------------------------- On Aug. 25, 2015, 3:53 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36321/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 3:53 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2061 and MESOS-2066 > https://issues.apache.org/jira/browse/MESOS-2061 > https://issues.apache.org/jira/browse/MESOS-2066 > > > Repository: mesos > > > Description > ------- > > MESOS-2061: Add Unavailability and InverseOffer protobufs declarations. > MESOS-2066: Add the Unavailability field to Offers. > > Also copied to v1 API. > > No integration with other components (that part is tracked in separate JIRAs, > see MESOS-1474). > > > Diffs > ----- > > include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 > include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 > > Diff: https://reviews.apache.org/r/36321/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
