> On Aug. 25, 2015, 9:55 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, line 129 > > <https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line129> > > > > For consistency, please one space between sentences! Here and below. > > Joseph Wu wrote: > The codebase isn't consistent in this respect. But grammatically, 2 > spaces is correct (notice that the ASF license text uses 2 spaces).
Not saying anything about grammatical correctness, I haven't found any 2 space comments in `mesos.proto`, except indents. Since 1 space is correct as well, let's be consistent. You're not updating the license, but the comment, right? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96126 ----------------------------------------------------------- On Aug. 25, 2015, 10:53 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36321/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 10:53 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2061 and MESOS-2066 > https://issues.apache.org/jira/browse/MESOS-2061 > https://issues.apache.org/jira/browse/MESOS-2066 > > > Repository: mesos > > > Description > ------- > > MESOS-2061: Add Unavailability and InverseOffer protobufs declarations. > MESOS-2066: Add the Unavailability field to Offers. > > Also copied to v1 API. > > No integration with other components (that part is tracked in separate JIRAs, > see MESOS-1474). > > > Diffs > ----- > > include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 > include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 > > Diff: https://reviews.apache.org/r/36321/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
