> On Aug. 3, 2015, 7:37 p.m., Ben Mahler wrote: > > src/master/http.cpp, lines 526-542 > > <https://reviews.apache.org/r/37024/diff/1/?file=1027286#file1027286line526> > > > > Could you include these fields as well? They capture "version" / > > "build" information. Once you do, perhaps it is worth adding a > > '`JSON::Object version()`' helper in common/http.hpp. > > Marco Massenzio wrote: > great point. > also wondering if, at this point, it would make sense to have a Protobuf > `VersionInfo` (that we could also use to replace the `version` string in > `MasterInfo`) which can then be used everywhere (and gets auto-converted to > JSON)? > > haosdent huang wrote: > Thank you @marco, it is OK for me. What's @bmahler opinion? :-P
Sounds good Marco! I think we'll punt on that in this review since it sounds like a change we could make independently of the /version endpoint. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review93947 ----------------------------------------------------------- On Aug. 16, 2015, 5:38 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37024/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2015, 5:38 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1841 > https://issues.apache.org/jira/browse/MESOS-1841 > > > Repository: mesos > > > Description > ------- > > Add an endpoint that exposes component version. > > > Diffs > ----- > > include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 > include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd > src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 > src/exec/exec.cpp 31e0c2f17a9092d18285828111d27628fb07bc02 > src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db > src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 > src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 > src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 > src/version/version_info.hpp PRE-CREATION > src/version/version_info.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37024/diff/ > > > Testing > ------- > > Manual test result: > > ``` > $ curl http://localhost:5050/version 2>/dev/null|jq . > > { > "version": "0.24.0", > "build_user": "haosdent", > "build_time": 1439702338, > "build_date": "2015-08-16 13:18:58" > } > ``` > > > Thanks, > > haosdent huang > >