> On Sept. 4, 2015, 6:59 a.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 203
> > <https://reviews.apache.org/r/37669/diff/10/?file=1063731#file1063731line203>
> >
> >     We remove the overflow components

Change “remove the rest components here before parsing the docker version” to 
"We remove the overflow components here before parsing the docker version", 
right?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review97732
-----------------------------------------------------------


On Sept. 4, 2015, 2:27 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37669/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 2:27 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen.
> 
> 
> Bugs: MESOS-2986
>     https://issues.apache.org/jira/browse/MESOS-2986
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignore overflow docker components in version parsing.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
>   src/tests/containerizer/docker_tests.cpp 
> cfad36850b40ade7a41f5b92255320ca1ed1bf93 
> 
> Diff: https://reviews.apache.org/r/37669/diff/
> 
> 
> Testing
> -------
> 
> # Add new test case
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="DockerTest.ROOT_DOCKER_parsing_version" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to