-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38125/#review97744
-----------------------------------------------------------



src/master/master.cpp (line 5847)
<https://reviews.apache.org/r/38125/#comment153760>

    Indent with 4 spaces and break after the opening brace to reduce jaggedness.



src/master/master.cpp (line 5849)
<https://reviews.apache.org/r/38125/#comment153763>

    s/"_S"/"-S"



src/tests/master_tests.cpp (line 3672)
<https://reviews.apache.org/r/38125/#comment153762>

    s/client/slave? Or what is meant with client?


- Jan Schlicht


On Sept. 4, 2015, 12:57 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38125/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 12:57 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-115
>     https://issues.apache.org/jira/browse/MESOS-115
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now including the hostname in the SlaveID, for human consumption. Also 
> testing this in a unit test.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
> 
> Diff: https://reviews.apache.org/r/38125/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Reply via email to