----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97743 -----------------------------------------------------------
Looks very good to me. src/master/master.cpp (lines 5847 - 5849) <https://reviews.apache.org/r/38125/#comment153761> How about preventing the variable indentation by concentrating on the fact that can be considered a parameter continuation; ``` slaveId.set_value( info_.id() + "_" + stringify(slaveInfo.hostname()) + "_" + stringify(slaveInfo.port()) + "_S" + stringify(nextSlaveId++)); ``` src/tests/master_tests.cpp (line 43) <https://reviews.apache.org/r/38125/#comment153757> Missing include for net::IP ``` #include <stout/ip.hpp> ``` src/tests/master_tests.cpp (line 3655) <https://reviews.apache.org/r/38125/#comment153759> Please add a heading comment that briefly describes this test in 1 or 2 lines. src/tests/master_tests.cpp (line 3657) <https://reviews.apache.org/r/38125/#comment153755> Seems rather obvious, does this comment really add any value? Also the first two comments use this "step-scheme" but then you dont follow that pattern anymore - I think we can safely remove both (start master and start slave). src/tests/master_tests.cpp (line 3676) <https://reviews.apache.org/r/38125/#comment153756> Lets add a blank line here. src/tests/master_tests.cpp (line 3678) <https://reviews.apache.org/r/38125/#comment153758> Insert blank line here, please - Till Toenshoff On Sept. 4, 2015, 10:57 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38125/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 10:57 a.m.) > > > Review request for mesos, Jan Schlicht and Till Toenshoff. > > > Bugs: MESOS-115 > https://issues.apache.org/jira/browse/MESOS-115 > > > Repository: mesos > > > Description > ------- > > Now including the hostname in the SlaveID, for human consumption. Also > testing this in a unit test. > > > Diffs > ----- > > src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 > src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac > src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 > > Diff: https://reviews.apache.org/r/38125/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
