----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97871 -----------------------------------------------------------
What is the benefit of this change? I'm a bit reluctant to conflate ID and additional information. A high-level question: can hostname change on the slave failover? If yes, we may end up in a situation, when the information in the `SlaveID` is misleading, which is worse than absence of it. - Alexander Rukletsov On Sept. 4, 2015, 10:57 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38125/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 10:57 a.m.) > > > Review request for mesos, Jan Schlicht and Till Toenshoff. > > > Bugs: MESOS-115 > https://issues.apache.org/jira/browse/MESOS-115 > > > Repository: mesos > > > Description > ------- > > Now including the hostname in the SlaveID, for human consumption. Also > testing this in a unit test. > > > Diffs > ----- > > src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 > src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac > src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 > > Diff: https://reviews.apache.org/r/38125/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
