> On Sept. 4, 2015, 7:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4118 > > <https://reviews.apache.org/r/38051/diff/1/?file=1062262#file1062262line4118> > > > > Instead of not calling updateTask() the logic should be inside > > updateTask() to do the right thing. Note that updateTask() already has > > logic to deal with duplicate terminal updates.
Also, needs a test! - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review97790 ----------------------------------------------------------- On Sept. 2, 2015, 1:13 p.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38051/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 1:13 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2864 > https://issues.apache.org/jira/browse/MESOS-2864 > > > Repository: mesos > > > Description > ------- > > Only update the task status when its old status is not terminal. > > > Diffs > ----- > > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > > Diff: https://reviews.apache.org/r/38051/diff/ > > > Testing > ------- > > > Thanks, > > Yong Qiao Wang > >
