> On 九月 4, 2015, 7:42 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 4118
> > <https://reviews.apache.org/r/38051/diff/1/?file=1062262#file1062262line4118>
> >
> >     Instead of not calling updateTask() the logic should be inside 
> > updateTask() to do the right thing. Note that updateTask() already has 
> > logic to deal with duplicate terminal updates.
> 
> Vinod Kone wrote:
>     Also, needs a test!

Thanks a billion for your many times review.  I have updated the changes by 
your usful comments.


- Yong Qiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review97790
-----------------------------------------------------------


On 九月 2, 2015, 1:13 p.m., Yong Qiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> -----------------------------------------------------------
> 
> (Updated 九月 2, 2015, 1:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2864
>     https://issues.apache.org/jira/browse/MESOS-2864
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only update the task status when its old status is not terminal.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
> 
> Diff: https://reviews.apache.org/r/38051/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Reply via email to