----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97846 -----------------------------------------------------------
include/mesos/v1/executor/executor.proto (line 47) <https://reviews.apache.org/r/38143/#comment153914> I think that the framework id need to be set when call "SUBSCRIBE" but not after "SUBSCRIBED"? include/mesos/v1/executor/executor.proto (line 55) <https://reviews.apache.org/r/38143/#comment153917> s/successfuly/successfully include/mesos/v1/executor/executor.proto (line 91) <https://reviews.apache.org/r/38143/#comment153918> s/arojas/yourid? include/mesos/v1/executor/executor.proto (line 169) <https://reviews.apache.org/r/38143/#comment153919> Do you mean that when type is Subscribe, there is no need to set any message? Why? I think that the framework id, executor id, command should be set? - Guangya Liu On 九月 5, 2015, 2:35 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38143/ > ----------------------------------------------------------- > > (Updated 九月 5, 2015, 2:35 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3375 > https://issues.apache.org/jira/browse/MESOS-3375 > > > Repository: mesos > > > Description > ------- > > Executor protobufswere introduced in Mesos for the HTTP API, they need to be > added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf > ought to be changed as the executor HTTP API design evolves. > > > Diffs > ----- > > include/mesos/v1/executor/executor.hpp PRE-CREATION > include/mesos/v1/executor/executor.proto PRE-CREATION > src/Makefile.am 5fdca0f > > Diff: https://reviews.apache.org/r/38143/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Isabel Jimenez > >
