> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote: > > include/mesos/v1/executor/executor.proto, line 169 > > <https://reviews.apache.org/r/38143/diff/1/?file=1064550#file1064550line169> > > > > Do you mean that when type is Subscribe, there is no need to set any > > message? Why? I think that the framework id, executor id, command should be > > set? > > Isabel Jimenez wrote: > The design here follows the design for the scheduler HTTP API. All call > and event messages require their type. Depending on the 'type' of call > message, you should expect an optional corresponding type of message. > For example if you have a 'Call' message of 'type' 'UPDATE' your call > message will have the optional 'update' message inside with their required > 'status' , 'timestamp' and 'uuid'.
Here you can find the design doc for the scheduler HTTP API: https://docs.google.com/document/d/1pnIY_HckimKNvpqhKRhbc9eSItWNFT-priXh_urR-T0/edit?usp=sharing - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97846 ----------------------------------------------------------- On Sept. 5, 2015, 10:05 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38143/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2015, 10:05 p.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3375 > https://issues.apache.org/jira/browse/MESOS-3375 > > > Repository: mesos > > > Description > ------- > > Executor protobufswere introduced in Mesos for the HTTP API, they need to be > added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf > ought to be changed as the executor HTTP API design evolves. > > > Diffs > ----- > > include/mesos/v1/executor/executor.hpp PRE-CREATION > include/mesos/v1/executor/executor.proto PRE-CREATION > src/Makefile.am 5fdca0f > > Diff: https://reviews.apache.org/r/38143/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Isabel Jimenez > >
