----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review98326 -----------------------------------------------------------
most (if not all) comments here pertain to the unversioned executor.proto as well. i would recommend sending a review for unversioned proto addressing these comments and make this review depend on it. that way, this review would be purely copy paste. include/mesos/v1/executor/executor.proto (line 42) <https://reviews.apache.org/r/38143/#comment154705> There is nothing in comments on 'Type' about shutdown. Just explain it here. include/mesos/v1/executor/executor.proto (lines 89 - 90) <https://reviews.apache.org/r/38143/#comment154704> Much like with the scheduler, invalid calls result in BadRequest. We should really update this wording in executor and scheduler protos. include/mesos/v1/executor/executor.proto (line 128) <https://reviews.apache.org/r/38143/#comment154708> s/acknoledged/acknowledged/ include/mesos/v1/executor/executor.proto (line 165) <https://reviews.apache.org/r/38143/#comment154713> This should be required ExecutorID similar to what we did with scheduler. Also means that we need a 'Subscribe' message. I would recommend renaming Resubscribe to Subscribe and adding ExecutorInfo to it. - Vinod Kone On Sept. 9, 2015, 11:09 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38143/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2015, 11:09 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3375 > https://issues.apache.org/jira/browse/MESOS-3375 > > > Repository: mesos > > > Description > ------- > > Executor protobufswere introduced in Mesos for the HTTP API, they need to be > added to /v1 so they reflect changes made on v1/mesos.proto. This protobuf > ought to be changed as the executor HTTP API design evolves. > > > Diffs > ----- > > include/mesos/v1/executor/executor.hpp PRE-CREATION > include/mesos/v1/executor/executor.proto PRE-CREATION > src/Makefile.am 5fdca0f > > Diff: https://reviews.apache.org/r/38143/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Isabel Jimenez > >