This is an automatically generated e-mail. To reply, visit:

docs/maintenance.md (line 9)

    s/maintenance is task affecting/can affect running tasks/

docs/maintenance.md (line 15)

    s/first sentence/Frameworks require visibility into the actions that 
disrupt cluster operation in order to be able to meet Service Level Agreemenets 
and/or to ensure uninterrupted service operation for the end users.

docs/maintenance.md (line 24)


docs/maintenance.md (line 25)

    s/These concepts are defined as the following:/Those concepts are:

docs/maintenance.md (line 27)

    s/an agent/a machine/

docs/maintenance.md (line 29)

    A set of machines with an associated period of time during which the 
maintenance is planned on those machines.

docs/maintenance.md (line 31)

    s/windows./windows each consisting of a unique set of machines.

docs/maintenance.md (line 32)

    s/A period/A tentative period/
    s/an associated agent/an associated machine/
    s/no guarantees can be made/no assumptions should be mage about the 
availability of Machine (or resources) past the unavailiability period./

docs/maintenance.md (line 35)

    Please mention that framework running on draining machines should receieve 
inverse offers, and that offers sent with resources from draining machines have 
unavailability set.

docs/maintenance.md (line 40)

    I would mention here the similiraty with normal offers.

docs/maintenance.md (line 53)

    Maintenance primitives were introduced in Mesos 0.25.0. With introduction 
of the primitive the following machine maintenance modes have also been added:

docs/maintenance.md (line 58)

    Why is this a Note?

docs/maintenance.md (line 65)

    s/For the operator..../To transition a machine into Draining mode an 
operator constructs a maintenance schedule and posts it to the Mesos master./

docs/maintenance.md (lines 68 - 72)

    Did not we describe this already?

docs/maintenance.md (line 77)

    Here we use will, and bellow we use could. Please go over the entire doc 
and make sure that the use of tense is consistent. Please check other Mesos 
docs and see which tense do they normally use.

docs/maintenance.md (line 93)

    Is it nanonsecods since UNIX epoch? Can we just use seconds in the eaxmaple?

docs/maintenance.md (line 118)

    s/currently part of the cluster/registered with Mesos master/.

docs/maintenance.md (line 120)


docs/maintenance.md (lines 120 - 122)

    We first speak about schedule, and then all of a sudden jump to deactivated 
machines. I would suggest to move the part about deactivated machines to a 
section below.

docs/maintenance.md (line 124)

    Were all the prior notes not important? ;)

docs/maintenance.md (line 128)

    s/need to/MUST/. In general I would susggest to go over the docment and 
make sure we consistently use MUST,SHOULD, MAY (a la 

docs/maintenance.md (line 137)

    what about duration? Can't we just leave it empty?

docs/maintenance.md (line 138)

    Can't we have deactivated machines outside a maintenance schedule?

docs/maintenance.md (line 142)

    s/a number of things/the following things/

docs/maintenance.md (lines 174 - 176)

    A framework can use a filter to control when it wants to be contacted again 
with the inverse offer. This is useful since....

docs/maintenance.md (lines 180 - 182)

    s/.*/Accepting an inverse offer is perceived as a best-effort promise by 
the framework to free all the resources contained in the inverse offer by the 
start of maintenance time.

docs/maintenance.md (line 194)


docs/maintenance.md (lines 213 - 218)

    incosistent use of may/must + present tense.

docs/maintenance.md (line 228)

    s/even if/even when/?

docs/maintenance.md (line 242)

    can we make sure that `above` is a link here?

docs/maintenance.md (line 243)


- Artem Harutyunyan

On Sept. 1, 2015, 10:42 a.m., Joseph Wu wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
> (Updated Sept. 1, 2015, 10:42 a.m.)
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> Bugs: MESOS-2083
>     https://issues.apache.org/jira/browse/MESOS-2083
> Repository: mesos
> Description
> -------
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> Includes a diagram of the maintenance mode transitions.
> This documents the current working prototype (MVP), which starts here:
> https://reviews.apache.org/r/36321/
> One TODO remaining: Update with the release version that maintenance 
> primitives will be released in.
> Diffs
> -----
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> Diff: https://reviews.apache.org/r/37585/diff/
> Testing
> -------
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> File Attachments
> ----------------
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> Thanks,
> Joseph Wu

Reply via email to