> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, lines 72-73
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line72>
> >
> >     Please add anchors to links so that the relevant parts of the .proto 
> > file in each case are highlighted.

I'll need to reference a specific commit then.  (See if you prefer it this way).


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 120
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line120>
> >
> >     What does this mean for the person reading this? Should they supply 
> > extra options through the agent command line? Should they make sure that 
> > their /etc/hosts is sane? This is currently not actionable, but it has to 
> > be.

I'll add the sentence:

If there is any ambiguity in a machine's configuration, the operator should use 
the `--hostname` and `--ip` options when starting agents.


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 127
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line127>
> >
> >     What if one or several of the checks fail?

Added:

If any of these properties are not met, the maintenance schedule is rejected 
with a corresponding error message and the master's state does not change.


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 133
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line133>
> >
> >     Isn't this one obvious?

I suppose so.  Removed.


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, lines 144-145
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line144>
> >
> >     Does this potentially mean a mass task restart across the nodes that 
> > are undergoing maintenance?

I'm not sure where you got this?


> On Sept. 18, 2015, 5:52 p.m., Artem Harutyunyan wrote:
> > docs/maintenance.md, line 190
> > <https://reviews.apache.org/r/37585/diff/11/?file=1076950#file1076950line190>
> >
> >     a link to .proto would be helpful here too.

A proto doesn't exist for this anymore :)

I can point to MachineID though.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99635
-----------------------------------------------------------


On Sept. 18, 2015, 6:27 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 6:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
>     https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -----
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> -------
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> ----------------
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to