> On Sept. 14, 2015, 12:37 a.m., Qian Zhang wrote: > > src/master/master.cpp, lines 4131-4134 > > <https://reviews.apache.org/r/37175/diff/7/?file=1071163#file1071163line4131> > > > > I think we have done this in Master::Http::maintenanceSchedule(), so > > why we do it again here? Maybe remove the duplicated code from > > Master::Http::maintenanceSchedule()?
You are right! Thanks for catching this :-) Fixed in updated review. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review98790 ----------------------------------------------------------- On Sept. 14, 2015, 12:46 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37175/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 12:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > fbf353d8bdd4322275057e392a958fca77ecd8b3 > src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80 > src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 > src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 > src/tests/master_maintenance_tests.cpp > fb8dca3757a9565d5eb5a69eed10aa34602bb15c > src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 > > Diff: https://reviews.apache.org/r/37175/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
