----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review96814 -----------------------------------------------------------
Ship it! include/mesos/master/allocator.hpp (line 138) <https://reviews.apache.org/r/37175/#comment152478> Please document what this function is for!!!! src/master/allocator/mesos/hierarchical.hpp (line 838) <https://reviews.apache.org/r/37175/#comment152482> // Any old maintenace ... slaves[slaveId].maintenance = None(); // If we have a new unavail .. if (unavailability.isSome()) { slaves[slaveId].maintenance = unavailaility.get(); } src/master/master.cpp (line 3830) <https://reviews.apache.org/r/37175/#comment152485> s/ip/IP/ src/master/master.cpp (line 3844) <https://reviews.apache.org/r/37175/#comment152486> s/ip/IP/ src/master/master.cpp (line 4164) <https://reviews.apache.org/r/37175/#comment152480> s/Note/NOTE/ src/tests/master_maintenance_tests.cpp (line 215) <https://reviews.apache.org/r/37175/#comment152489> How about moving this to the test fixture? src/tests/master_maintenance_tests.cpp (line 217) <https://reviews.apache.org/r/37175/#comment152484> Do you need the 'this->' here? My guess is not because this isn't a templated test, but you probably copied this from a templated test. Also, let's implement 'CreateSlaveFlags' in the test fixture so all tests get this and then we can just call 'StartSlave' without having to pass it any flags. src/tests/master_maintenance_tests.cpp (line 219) <https://reviews.apache.org/r/37175/#comment152483> Newline between these two "thoughts" please. src/tests/master_maintenance_tests.cpp (line 261) <https://reviews.apache.org/r/37175/#comment152488> s/Duration/Time/ src/tests/master_maintenance_tests.cpp (lines 289 - 290) <https://reviews.apache.org/r/37175/#comment152487> Can we make a comparison operator for TimeInfo and Time? - Benjamin Hindman On Aug. 26, 2015, 2:12 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37175/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 2:12 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > 38f8fd2c84314bb3731684d0e9795cb4f50a227e > src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 > src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/tests/master_maintenance_tests.cpp PRE-CREATION > src/tests/mesos.hpp 637636ac69dde02da6b7200d7c666cac89b051cb > > Diff: https://reviews.apache.org/r/37175/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
