----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review97527 -----------------------------------------------------------
Ship it! include/mesos/master/allocator.hpp (lines 138 - 141) <https://reviews.apache.org/r/37175/#comment153481> Consider Doxygen-ification. src/master/http.cpp (lines 1448 - 1450) <https://reviews.apache.org/r/37175/#comment153482> You'll probably want to delete this line, since `updateUnavailability` does that for us. src/master/http.cpp (line 1466) <https://reviews.apache.org/r/37175/#comment153486> You'll probably want to delete this line, since `updateUnavailability` does that for us. src/tests/master_maintenance_tests.cpp (lines 360 - 361) <https://reviews.apache.org/r/37175/#comment153491> Rebase mistake? - Joseph Wu On Sept. 2, 2015, 12:31 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37175/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 12:31 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > 38f8fd2c84314bb3731684d0e9795cb4f50a227e > src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e > src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > src/tests/master_maintenance_tests.cpp > fb8dca3757a9565d5eb5a69eed10aa34602bb15c > src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 > > Diff: https://reviews.apache.org/r/37175/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
