> On 九月 16, 2015, 3:09 p.m., Alexander Rukletsov wrote:
> > Last minor nit: we tend to use past tense in summary and prepend the commit 
> > message with "libprocess" for libprocess changes. Also, not a trailing 
> > period. That's how it may be rewritten:
> > "libprocess: Replaced hard-coded reap interval with a constant."
> > 
> > Description is in present, but you don't need any in this case.
> > 
> > Last, but not least: though not that many people adhere to this style, it's 
> > sometimes benefitial to mention on what platforms did you run `make check` 
> > or `make distcheck`. Shouldn't make a difference for this patch though.

Thanks Alex, updated.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38168/#review99224
-----------------------------------------------------------


On 九月 16, 2015, 4:07 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38168/
> -----------------------------------------------------------
> 
> (Updated 九月 16, 2015, 4:07 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-1935
>     https://issues.apache.org/jira/browse/MESOS-1935
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> libprocess: Replaced hard-coded reap interval with a constant.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 
> 642ab97b28a6085dc9837f14ff36a3124387a03b 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> ab7515325e5db0a4fd222bb982f51243d7b7e39d 
> 
> Diff: https://reviews.apache.org/r/38168/diff/
> 
> 
> Testing
> -------
> 
> OS: Ubuntu 14.04
> make distcheck
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to